There is an issue with the Finder where at times the setting of the icon does not work. When this happens you typically end up with a generic blue folder icon. This is more common when you repeatably change the icon on a single folder. If this happens...wait a few seconds and try again. Typically this will fix the issue. Note that we are being told that everything worked even though it is visibly failing.
Additional topics: