Welcome Guest

Pages: 1
Error Handling for Access AcousticBrainz
skyfingerPostNovember 6, 2015, 16:03
Newbie
Posts: 20
Registered:
October 7, 2015, 18:55
Normal topicError Handling for Access AcousticBrainz

I'm using Access AcousticBrainz to get the BPM if empty. It works great if the AcousticBrainz entry has a BPM field. Sometimes, though, I'll get a 404 error.

For example, this recording: http://musicbrainz.org/recording/a2758e35-610a-4ac8-b87b-3e2f86920cbc an AcoustID 4d10d202-121f-4caf-aac4-21391eaa32b2 http://acoustid.org/track/4d10d202-121f-4caf-aac4-21391eaa32b2, which is somehow linked to 2 MusicBrainz recordings.

How can I handle this in the Action?

I saw the Test function, but couldn't exactly figure it out after reading the documentation.

2MR2PostNovember 6, 2015, 16:21
Avatar photo
Administrator
Posts: 2085
Registered:
August 23, 2012, 19:27
Normal topicRe: Error Handling for Access AcousticBrainz

Hmm... there is no way to test if it worked other than checking if the BPM and /or key was changed. I can easily add a 'silent' option and possibly set the action test state to true if something was imported. Alternately, I can simply ignore 404s and you can check if anything was actually imported. That will be quicker as no UI changes will be required. In this case the later is okay should be okay as no changes either implies the value you have was correct or there was nothing to import.

Let me se what can be done quickly.

2MR2PostNovember 6, 2015, 17:11
Avatar photo
Administrator
Posts: 2085
Registered:
August 23, 2012, 19:27
Normal topicRe: Error Handling for Access AcousticBrainz

Check your email for a prerelease patch.

skyfingerPostNovember 9, 2015, 23:55
Newbie
Posts: 20
Registered:
October 7, 2015, 18:55
Normal topicRe: Error Handling for Access AcousticBrainz

Thanks. The patch is working well. Personally, I'm partial to just ignoring 404s altogether, since there's not much we can do about them, and I really wasn't expecting that. I'm guessing that there could be other errors like timing out, server down, etc.

2MR2PostNovember 10, 2015, 08:03
Avatar photo
Administrator
Posts: 2085
Registered:
August 23, 2012, 19:27
Normal topicRe: Error Handling for Access AcousticBrainz

Far too many networking errors and how they propagate is a pain. A few weeks ago there was a panic when one of the online data sources' servers were passing 'zero results' for everything as opposed to indicating a 'down' condition.

skyfingerPostNovember 12, 2015, 18:54
Newbie
Posts: 20
Registered:
October 7, 2015, 18:55
Normal topicRe: Error Handling for Access AcousticBrainz

Indeed it is. Lots of 503 errors. Still, they do a pretty amazing job considering it's a non-profit and all.

So does the checkbox for "ignore errors" apply to 404s and 503?

The 404 just means there isn't something to pull from to populate BPM and Key. From what I've read / heard, it's relatively new capability, and not all files have them. So with a 404 error, you could re-run it as many times as you wanted and would get the same result (until someone populated the database with the info). So, IMHO, it's not really an "error" per se, especially if the documentation mentions it might not be available for every song.

A 503 error (or whatever) could be a lot of things, and it would be good to know it's something to try again, just not right now.

So while I (rather, most people, I'm guessing) wouldn't care about the specifics of the error, they might care if it was a temporary one or not.

skyfingerPostNovember 12, 2015, 18:59
Newbie
Posts: 20
Registered:
October 7, 2015, 18:55
Normal topicRe: Error Handling for Access AcousticBrainz

Indeed it is. Lots of 503 errors. Still, they do a pretty amazing job considering it's a non-profit and all.

So does the checkbox for "ignore errors" apply to 404s and 503?

The 404 just means there isn't something to pull from to populate BPM and Key. From what I've read / heard, it's relatively new capability, and not all files have them. So with a 404 error, you could re-run it as many times as you wanted and would get the same result (until someone populated the database with the info). So, IMHO, it's not really an "error" per se, especially if the documentation mentions it might not be available for every song.

A 503 error (or whatever) could be a lot of things, and it would be good to know it's something to try again, just not right now.

So while I (rather, most people, I'm guessing) wouldn't care about the specifics of the error, they might care if it was a temporary one or not.

skyfingerPostNovember 12, 2015, 19:03
Newbie
Posts: 20
Registered:
October 7, 2015, 18:55
Normal topicRe: Error Handling for Access AcousticBrainz

The double post was, ironically, from a 500 error. I reloaded, and posted twice. Fun.

2MR2PostNovember 12, 2015, 19:10
Avatar photo
Administrator
Posts: 2085
Registered:
August 23, 2012, 19:27
Normal topicRe: Error Handling for Access AcousticBrainz

The way the patch is implemented is that all network errors are ignored. The "ignore errors" option simply suppresses an error message. I recently implemented the ability to detect 503s on MusicBrainz accesses. Even though Yate is extremely strict about the rate limiting rules there are still situations outside our control which result in a 503. For instance, they might temporarily refuse requests from a particular IP address.

I need a better and more general solution to make the network response codes available for all networking statements. However some commands (such as Access AcousticBrainz) issue multiple requests when operating in stepwise execution mode. For example let's say you issue an Access AcousticBrainz on 10 files and one returns a 503. There is no easy way to associate the response code with the offender. 🙁 I'd have to set a UDTI such as '503' or 'AcousticBrainz 503' or something....and that would get preserved if you saved the file. Most users don't like unexpected metadata.

Pages: 1
Mingle Forum by Cartpauj | Version: 1.1.0beta | Page loaded in: 0.023 seconds.